A surgical instrument having an end effector mounted on the end of an elongate shaft extending from a handle is described, the shaft and end effector being rotatable with respect to the housing, to allow different rotational orientations of the end effector to be attained without rotating the whole instrument. To provide for control over the degree of rotation, shaft rotation control elements are provided to give rotation or torsion control. The shaft rotation control elements may be located at several different longitudinal positions along the shaft. Alternatively, rotation control elements in the form of mutually co-operating stops may be provided elsewhere, such as in a rotatable shaft support member at the distal end of the handle. In other embodiments rotation control stops are provided on both elements, thus providing for effective rotation control, which has a high quality feel to the user.