A battery compartment for electronic cigarette comprising: support 20 defining mounting hole 21, locating holes 22, first through holes 23 on lateral sides and switch button 61 accommodated in the support and facing the mounting hole; an elastic element 70 (preferably spring or silicone gasket) abutting the button, passing through the mounting hole and abutting the switch button; a rotatable button 40 covering the support with a connector assembly 41 with second through holes 410 and configured to be inserted into locating hole, with a shaft 80 passing through first and second holes. Preferably, button comprises support block 43 accommodated in insert groove 24. A battery compartment comprising: support; housing sleeved on the support; PCB in the support; button covering the housing and with revolving shaft and connector clips; the support comprising connecting piece for shaft; and the connecting clip configured to pass through support to PCB.