A bait feeder 2 for casting bait for fish comprising a body portion 4 for receiving the bait, a weight portion 6 for providing a weight required by the feeder for enabling the feeder to be cast to a required casting distance and fastener means 8, a bayonet fastening, for releasably fastening the weight portion to the body portion. The weight portion is changeable on the body portion for ensuring that the feeder always has an optimum weight for enabling the feeder to be cast to the required casting distance. The feeder further includes indicator means 10, in the form of a protrusion (12, fig 1) and detent 14, for indicating when the weight portion is securely fastened on the body portion. The indicator means may operate such that location of the protrusion in the detent causes an audible noise and/or can be felt. Line connection means 34 may also be provided.