A device for providing positive expiratory pressure therapy to a patient wherein exhaled air is at a comparatively higher pressure than atmospheric pressure, said device including a container to hold liquid, an air inlet means to allow entry of air into the container and an air outlet to allow air to vent from the container. The air inlet means includes a conduit to discharge the exhaled air. The conduit is fixed in position so that the exhaled air is discharged at or substantially adjacent the base of the container. In use liquid is introduced into the container to a predetermined level and the bottom of the conduit is below the predetermined level of liquid to provide a desired level of positive pressure and the air outlet is above the predetermined level of liquid.